Skip to content

Commit

Permalink
[bugfix] Align timing of interface coalescing and range update. #triv…
Browse files Browse the repository at this point in the history
…ial (TextureGroup#847)

* fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449

* Fix to make rangeMode update in right time

* This is for cases when CollectionNode is created in cell of another collectionNode, the interfaceState(say didEnterVisible) is not called as expected.

It's because interfaceCoalescing alter the time line and cause RangeController update before actual interface applied.
  • Loading branch information
wsdwsd0829 authored and bernieperez committed Apr 25, 2018
1 parent 2ac6cd8 commit 55256a3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Source/ASDisplayNodeExtras.mm
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ extern ASInterfaceState ASInterfaceStateForDisplayNode(ASDisplayNode *displayNod
// Directly clear the visible bit if we are not in a window. This means that the interface state is,
// if not already, about to be set to invisible as it is not possible for an element to be visible
// while outside of a window.
ASInterfaceState interfaceState = displayNode.interfaceState;
ASInterfaceState interfaceState = displayNode.pendingInterfaceState;
return (window == nil ? (interfaceState &= (~ASInterfaceStateVisible)) : interfaceState);
} else {
// For not range managed nodes we might be on our own to try to guess if we're visible.
Expand Down

0 comments on commit 55256a3

Please sign in to comment.