forked from TextureGroup/Texture
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ASScrollNode] Fix small bugs and add unit tests (TextureGroup#637)
* Add unit tests for ASScrollNode * Make sure ASScrollNode's size is clamped against its size range * Invalidate ASScrollNode's calculated layout if its scrollable directions changed * Update comment * Update CHANGELOG * Address Adlai's comments
- Loading branch information
1 parent
79e5130
commit 92d52a4
Showing
4 changed files
with
153 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| // | ||
| // ASScrollNodeTests.m | ||
| // Texture | ||
| // | ||
| // Copyright (c) 2017-present, Pinterest, Inc. All rights reserved. | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
|
|
||
| #import <UIKit/UIKit.h> | ||
| #import <XCTest/XCTest.h> | ||
| #import <AsyncDisplayKit/AsyncDisplayKit.h> | ||
| #import "ASXCTExtensions.h" | ||
|
|
||
| @interface ASScrollNodeTests : XCTestCase | ||
|
|
||
| @property (nonatomic) ASScrollNode *scrollNode; | ||
| @property (nonatomic) ASDisplayNode *subnode; | ||
|
|
||
| @end | ||
|
|
||
| @implementation ASScrollNodeTests | ||
|
|
||
| - (void)setUp | ||
| { | ||
| ASDisplayNode *subnode = [[ASDisplayNode alloc] init]; | ||
| self.subnode = subnode; | ||
|
|
||
| self.scrollNode = [[ASScrollNode alloc] init]; | ||
| self.scrollNode.scrollableDirections = ASScrollDirectionVerticalDirections; | ||
| self.scrollNode.automaticallyManagesContentSize = YES; | ||
| self.scrollNode.automaticallyManagesSubnodes = YES; | ||
| self.scrollNode.layoutSpecBlock = ^ASLayoutSpec * _Nonnull(__kindof ASDisplayNode * _Nonnull node, ASSizeRange constrainedSize) { | ||
| return [[ASWrapperLayoutSpec alloc] initWithLayoutElement:subnode]; | ||
| }; | ||
| [self.scrollNode view]; | ||
| } | ||
|
|
||
| - (void)testSubnodeLayoutCalculatedWithUnconstrainedMaxSizeInScrollableDirection | ||
| { | ||
| CGSize parentSize = CGSizeMake(100, 100); | ||
| ASSizeRange sizeRange = ASSizeRangeMake(parentSize); | ||
|
|
||
| [self.scrollNode layoutThatFits:sizeRange parentSize:parentSize]; | ||
|
|
||
| ASSizeRange subnodeSizeRange = sizeRange; | ||
| subnodeSizeRange.max.height = CGFLOAT_MAX; | ||
| XCTAssertEqual(self.scrollNode.scrollableDirections, ASScrollDirectionVerticalDirections); | ||
| ASXCTAssertEqualSizeRanges(self.subnode.constrainedSizeForCalculatedLayout, subnodeSizeRange); | ||
|
|
||
| // Same test for horizontal scrollable directions | ||
| self.scrollNode.scrollableDirections = ASScrollDirectionHorizontalDirections; | ||
| [self.scrollNode layoutThatFits:sizeRange parentSize:parentSize]; | ||
|
|
||
| subnodeSizeRange = sizeRange; | ||
| subnodeSizeRange.max.width = CGFLOAT_MAX; | ||
|
|
||
| ASXCTAssertEqualSizeRanges(self.subnode.constrainedSizeForCalculatedLayout, subnodeSizeRange); | ||
| } | ||
|
|
||
| - (void)testAutomaticallyManagesContentSizeUnderflow | ||
| { | ||
| CGSize subnodeSize = CGSizeMake(100, 100); | ||
| CGSize parentSize = CGSizeMake(100, 200); | ||
| ASSizeRange sizeRange = ASSizeRangeUnconstrained; | ||
|
|
||
| self.subnode.style.preferredSize = subnodeSize; | ||
|
|
||
| [self.scrollNode layoutThatFits:sizeRange parentSize:parentSize]; | ||
| [self.scrollNode layout]; | ||
|
|
||
| ASXCTAssertEqualSizes(self.scrollNode.calculatedSize, parentSize); | ||
| ASXCTAssertEqualSizes(self.scrollNode.view.contentSize, subnodeSize); | ||
| } | ||
|
|
||
| - (void)testAutomaticallyManagesContentSizeOverflow | ||
| { | ||
| CGSize subnodeSize = CGSizeMake(100, 500); | ||
| CGSize parentSize = CGSizeMake(100, 200); | ||
| ASSizeRange sizeRange = ASSizeRangeUnconstrained; | ||
|
|
||
| self.subnode.style.preferredSize = subnodeSize; | ||
|
|
||
| [self.scrollNode layoutThatFits:sizeRange parentSize:parentSize]; | ||
| [self.scrollNode layout]; | ||
|
|
||
| ASXCTAssertEqualSizes(self.scrollNode.calculatedSize, parentSize); | ||
| ASXCTAssertEqualSizes(self.scrollNode.view.contentSize, subnodeSize); | ||
| } | ||
|
|
||
| - (void)testAutomaticallyManagesContentSizeWithSizeRangeSmallerThanParentSize | ||
| { | ||
| CGSize subnodeSize = CGSizeMake(100, 100); | ||
| CGSize parentSize = CGSizeMake(100, 500); | ||
| ASSizeRange sizeRange = ASSizeRangeMake(CGSizeMake(100, 100), CGSizeMake(100, 200)); | ||
|
|
||
| self.subnode.style.preferredSize = subnodeSize; | ||
|
|
||
| [self.scrollNode layoutThatFits:sizeRange parentSize:parentSize]; | ||
| [self.scrollNode layout]; | ||
|
|
||
| ASXCTAssertEqualSizes(self.scrollNode.calculatedSize, sizeRange.max); | ||
| ASXCTAssertEqualSizes(self.scrollNode.view.contentSize, subnodeSize); | ||
| } | ||
|
|
||
| - (void)testAutomaticallyManagesContentSizeWithSizeRangeBiggerThanParentSize | ||
| { | ||
| CGSize subnodeSize = CGSizeMake(100, 200); | ||
| CGSize parentSize = CGSizeMake(100, 100); | ||
| ASSizeRange sizeRange = ASSizeRangeMake(CGSizeMake(100, 150)); | ||
|
|
||
| self.subnode.style.preferredSize = subnodeSize; | ||
|
|
||
| [self.scrollNode layoutThatFits:sizeRange parentSize:parentSize]; | ||
| [self.scrollNode layout]; | ||
|
|
||
| ASXCTAssertEqualSizes(self.scrollNode.calculatedSize, sizeRange.min); | ||
| ASXCTAssertEqualSizes(self.scrollNode.view.contentSize, subnodeSize); | ||
| } | ||
|
|
||
| - (void)testAutomaticallyManagesContentSizeWithInvalidCalculatedSizeForLayout | ||
| { | ||
| CGSize subnodeSize = CGSizeMake(100, 200); | ||
| CGSize parentSize = CGSizeMake(CGFLOAT_MAX, CGFLOAT_MAX); | ||
| ASSizeRange sizeRange = ASSizeRangeUnconstrained; | ||
|
|
||
| self.subnode.style.preferredSize = subnodeSize; | ||
|
|
||
| [self.scrollNode layoutThatFits:sizeRange parentSize:parentSize]; | ||
| [self.scrollNode layout]; | ||
|
|
||
| ASXCTAssertEqualSizes(self.scrollNode.calculatedSize, subnodeSize); | ||
| ASXCTAssertEqualSizes(self.scrollNode.view.contentSize, subnodeSize); | ||
| } | ||
|
|
||
| @end |