Rust - Update README.md to use correct method #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello! I was trying the example given in the Getting Started section of README and it looks like `SetNoiseType` method has been renamed to `set_noise_type`. Therefore, I'm proposing this change!
|
@Keavon Does this look correct? |
|
Yep! This PR beat me to it. I finally got around to implementing this library into Graphite a few weeks ago and ran into this, so I was planning to submit a fix when I got the time. I'm glad @SayYoungMan was able to save me the trouble! I will probably also do one more pass through the entire API documentation before I suggest we bump the version numbers, give me a few days to submit a PR for that. Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I was trying the example given in the Getting Started section of README and it looks like
SetNoiseTypemethod has been renamed toset_noise_typeand the method signature seems to takeOption<NoiseType>as an argument.