-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the usage of getConfiguration('autolispext') by modify the extensionDevelopmentPath #141
base: main
Are you sure you want to change the base?
Conversation
// CloseParenthesisStyle: 'New line with outer indentation' | ||
// LongListFormatStyle: 'Fill to margin' | ||
// Need to remove the \r to do the format output compare | ||
after(async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suite doesn't have after / before.
It should use setup, teardown, suiteSetup, suiteTeardown.
https://www.w3resource.com/mocha/interfaces.php
@@ -22,6 +22,7 @@ | |||
"preLaunchTask": "buildproject", | |||
"runtimeExecutable": "${execPath}", | |||
"args": [ | |||
"--disable-extensions", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was handled in PR #160 and quite a bit more. Make sure you update to the latest before these test additions get added.
@@ -6,7 +6,8 @@ async function main() { | |||
try { | |||
// The folder containing the Extension Manifest package.json | |||
// Passed to `--extensionDevelopmentPath` | |||
const extensionDevelopmentPath = path.resolve(__dirname, '../../../../'); | |||
// The __dirname is \AutoLispExt\out\test | |||
const extensionDevelopmentPath = path.resolve(__dirname, '../../'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was handled in PR #160 and quite a bit more. Make sure you update to the latest before these test additions get added.
Objective
Update to use the correct extensionDevelopmentPath and remove mock method
Abstractions
In our lisp extension test we have wrongly set the extensionDevelopmentPath in runTest.ts so that it will fail to read the configuration('autolispext') and we have to use a workround of mock method for formatter.test.ts
In this subimission I corrected the extensionDevelopmentPath and removed the mock method
Tests performed
Passed local and CI test
Screen shot