Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autocompletionProvider.ts #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aeo000000
Copy link

Objective
  1. Show help description in pop menu of suggestions.( the function name 'vla-set-XXX' must change to 'vla-put-XXX' in webHelpAbstraction.json,its bug)

  2. VScode has some issues to check the "word" range, exp: type "vl-str" and type esc or backspace, continue to type "ing" and select 'vl-string->list' from menu,it will be: 'vl-vl-string->list' .
    Improved this problem, although it has not been completely solved, for example, typing ‘’-’’ still cannot be displayed as a complete word

Abstractions
Tests performed
Screen shot

image

1. Show help description in pop menu of suggestions.( the function name 'vla-set-XXX' must change to 'vla-put-XXX'  in webHelpAbstraction.json,its bug)

2. VScode has some issues to check the "word" range, exp: type "vl-str" and type esc or backspace,  continue to type "ing" and select 'vl-string->list' from menu,it will be: 'vl-vl-string->list' . 
Improved this problem, although it has not been completely solved, for example, typing ‘’-’’ still cannot be displayed as a complete word
@LanDong-adsk
Copy link
Contributor

Hello @aeo000000 , before we can merge your PR, please sign this file and send to me ([email protected]). thanks!
https://github.com/Autodesk-AutoCAD/AutoLispExt/blob/main/Autodesk_Form_Ind_Contrib_Agmt_for_Open_%20Source.pdf

@JD-Howard
Copy link
Collaborator

JD-Howard commented Jun 6, 2021

@aeo000000 Bullet-1 really needs to be fixed in the C#/JSON. Treating the symptom isn't really a solution.

I really should have noticed this, but think the biggest reason I missed it has to do with your Bullet-2. There are all kinds of things I use in lisp (like colons) that yield nothing worth using so I don't even pay attention to intellisense involving any special characters.

Anyway, unless you really want to dig into a complete nightmare, I'll go fix Bullet-1 in the C#/JSON. I actually plan to rewrite that "prototype" producing the JSON to be more sustainable and with better technologies sometime in the coming months.

// let pos = position.character;
// pos -= 2;
// let length = 1;
// let hasSetLen = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't need the codes, please remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants