Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date resets when reactivating an expired listing #653

Closed
danjjohnson opened this issue Apr 13, 2016 · 5 comments
Closed

Date resets when reactivating an expired listing #653

danjjohnson opened this issue Apr 13, 2016 · 5 comments
Labels
[Pri] Normal [Type] Bug
Milestone
1.25.2

Comments

@danjjohnson
Copy link
Contributor

What I Expected To Happen

  • Edit an expired listing in wp-admin
  • Change the expiry date to a future date, and click Publish
  • I expected the job status to be active with the new expiry date I set.

What Happened Instead

  • When you click Publish, the job status is active, but the new expiry date disappears and you have to set it again.

Steps to Reproduce the Bug

  • Edit an expired job
  • Change the expiry date to a future date
  • Publish the job

2623029-t
@MADagency
Copy link

Hello
Did you manage to solve this issue ?

@SwissMediaDesign
Copy link

No, unfortunately not. We are still waiting for a solution.

@MADagency
Copy link

thanks for you reply ;-)

@chaselivingston chaselivingston added this to the 1.25.1 milestone Aug 5, 2016
@donnchawp
Copy link
Contributor

It looks like the problem is in set_expiry() in class-wp-job-manager-post-types.php - it checks for the stored value of the expiry date, but not the POST value, and then resets the POST value and returns.

donnchawp added a commit that referenced this issue Oct 12, 2016
@donnchawp
Don't blindly delete the expiry postmeta value and not process the fo…
1620c9d 
…rm value

Fixes #653
The code was checking the expiry value stored in the db and returning if it was expired (which it was when editing an expired job), so the new expired value wasn't being processed.
@donnchawp donnchawp mentioned this issue Oct 12, 2016
Merged
@donnchawp
Copy link
Contributor

#782 should fix it but I'd like to see some testing of it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Pri] Normal [Type] Bug
Projects
None yet
Milestone
1.25.2
Development

No branches or pull requests
5 participants
@chaselivingston @danjjohnson @donnchawp @MADagency @SwissMediaDesign