broadcast callback on non shared variables #1441

FredLL-Avaiga · 2024-06-21T13:57:14Z

resolves #1207

~~renamed current broadcast_callback to broadcast_callback_on_shared~~

resolves #1207

github-actions · 2024-06-21T14:03:13Z

Coverage report for `frontend/taipy-gui`

Branches coverage not met for global: expected >=80%, but got 62.079943402900604%

St.^❔	Category	Percentage	Covered / Total
🟢	Statements	80.86% (+0.14% 🔼)	2776/3433
🟡	Branches	62.08% (-0.55% 🔻)	1755/2827
🟡	Functions	74.12% (-0.19% 🔻)	487/657
🟢	Lines	81.49% (+0.14% 🔼)	2585/3172

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / Dialog.tsx	80.43%	60.87%	100%	80.43%
🟡	`...` / TaipyRendered.tsx	64.58%	14.29%	50%	64.58%
🟡	`...` / index.ts	75.51%	26.67%	50%	75%
🟢	`...` / Expandable.tsx	100%	85%	100%	100%
🟢	`...` / PageContent.tsx	75%	100%	0%	100%
🟢	`...` / Pane.tsx	95.12%	73.81%	100%	94.87%
🟢	`...` / Part.tsx	88%	64.29%	75%	91.3%
🟡	`...` / Unregistered.tsx	62.5%	0%	0%	60%

Test suite run success

400 tests passing in 41 suites.

Report generated by 🧪jest coverage report action from 824c9fa

FabienLelaquais · 2024-06-21T15:25:51Z

I think this PR is also trying to fix something that was a glitch.

@dinhlongviolin1 I need your blessing here.
This broadcast_callback_on_shared() to me is useless: the 'shared' state is not known by users, and should actually never been exposed.
What I expect broadcast_callback() to do is invoke a user-defined function, potentially with parameters, for every live state.
If then the user invokes state.assign() fine, so be it. But let the user decide.
What do you think?

Another important question is: does anyone see a use case for the _on_shared version?
Because I don't see any, and I'm willing to drop all this code...

Thanks!

dinhlongviolin1 · 2024-06-22T07:37:36Z

I think this PR is also trying to fix something that was a glitch.

@dinhlongviolin1 I need your blessing here. This broadcast_callback_on_shared() to me is useless: the 'shared' state is not known by users, and should actually never been exposed. What I expect broadcast_callback() to do is invoke a user-defined function, potentially with parameters, for every live state. If then the user invokes state.assign() fine, so be it. But let the user decide. What do you think?

Another important question is: does anyone see a use case for the _on_shared version? Because I don't see any, and I'm willing to drop all this code...

Thanks!

I think you are right on this one and I agree. We should drop this code as I myself don't see a use case for it. Don't remember why I add it but hopefully it wont affect anything. @FredLL-Avaiga Please help me drop it in this PR 😺

FredLL-Avaiga · 2024-06-22T08:12:03Z

I think this PR is also trying to fix something that was a glitch.

@dinhlongviolin1 I need your blessing here. This broadcast_callback_on_shared() to me is useless: the 'shared' state is not known by users, and should actually never been exposed. What I expect broadcast_callback() to do is invoke a user-defined function, potentially with parameters, for every live state. If then the user invokes state.assign() fine, so be it. But let the user decide. What do you think?

Another important question is: does anyone see a use case for the _on_shared version? Because I don't see any, and I'm willing to drop all this code...

Thanks!

I think you are right on this one and I agree. We should drop this code as I myself don't see a use case for it. Don't remember why I add it but hopefully it wont affect anything. @FredLL-Avaiga Please help me drop it in this PR 😺

I will drop it then

- add state to global ctx to allow use of state in function call used as bound value

FabienLelaquais

I would like to be closer to the legacy example.

doc/gui/examples/broadcast.py

frontend/taipy-gui/src/components/Taipy/PaginatedTable.tsx

taipy/gui/gui.py

doc/gui/examples/broadcast.py

github-actions · 2024-06-24T11:29:06Z

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
18463	16079	87%	0%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
taipy/gui/gui.py	81%	🟢
taipy/gui/gui_actions.py	69%	🟢
taipy/gui_core/_context.py	55%	🟢
TOTAL	68%	🟢

updated for commit: 824c9fa by action🐍

FredLL-Avaiga · 2024-06-25T16:17:21Z

can't approve as I am still an assignee but I would.
@FabienLelaquais I thought you wanted to add a Gui.broadcast(var_name: str, value: t.Any) that would call Gui.broadcast_callback ?

FredLL-Avaiga · 2024-06-25T16:17:35Z

I would if you update the branch ;-)

FabienLelaquais · 2024-06-25T16:21:21Z

I would if you update the branch ;-)

Let me confess I completely forgot.
Thanks!

github-actions · 2024-06-29T14:46:34Z

Coverage report for `./frontend/taipy-gui`

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 62.079943402900604%

St.^❔	Category	Percentage	Covered / Total
🟢	Statements	80.86% (+0.42% 🔼)	2776/3433
🟡	Branches	62.08% (-0.31% 🔻)	1755/2827
🟡	Functions	74.12% (+0.16% 🔼)	487/657
🟢	Lines	81.49% (+0.46% 🔼)	2585/3172

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / Dialog.tsx	80.43%	60.87%	100%	80.43%
🟡	`...` / TaipyRendered.tsx	64.58%	14.29%	50%	64.58%
🟡	`...` / index.ts	75.51%	26.67%	50%	75%
🟢	`...` / Expandable.tsx	100%	85%	100%	100%
🟢	`...` / PageContent.tsx	75%	100%	0%	100%
🟢	`...` / Pane.tsx	95.12%	73.81%	100%	94.87%
🟢	`...` / Part.tsx	88%	64.29%	75%	91.3%
🟡	`...` / Unregistered.tsx	62.5%	0%	0%	60%

Test suite run success

400 tests passing in 41 suites.

Report generated by 🧪jest coverage report action from fe16d5c

FredLL-Avaiga

👍

FabienLelaquais

Looking good!

FabienLelaquais

➕

namnguyen20999

LGTM

dinhlongviolin1

Amazingly done!

FabienLelaquais

👍

broadcast callback on non shared variables

e32089a

resolves #1207

FredLL-Avaiga added 🟥 Priority: Critical Must be addressed as soon as possible ✨New feature 📝Release Notes Impacts the Release Notes Gui: Back-End labels Jun 21, 2024

FredLL-Avaiga requested review from namnguyen20999, dinhlongviolin1 and FabienLelaquais June 21, 2024 13:57

FredLL-Avaiga self-assigned this Jun 21, 2024

update example

d5b1f63

remove shared from the broadcast example

81d12e5

Fred Lefévère-Laoide and others added 3 commits June 24, 2024 09:32

- remove broadcast_callback_on_shared

ac82a43

- add state to global ctx to allow use of state in function call used as bound value

Merge branch 'develop' into feature/#1207-broadcast-callback

3561dc4

remove broadcast_callback_on_shared

6a5253d

FabienLelaquais requested changes Jun 24, 2024

View reviewed changes

Fred Lefévère-Laoide added 2 commits June 24, 2024 10:13

some of Fab's comments

28ea567

some of Fab's comments

8082e25

FredLL-Avaiga requested a review from FabienLelaquais June 24, 2024 08:14

Merci les tests

1378062

Expose invoke_callback() and broadcast_callback() as Gui methods.

824c9fa

FredLL-Avaiga assigned FabienLelaquais Jun 25, 2024

Added Gui.broadcast_change() and gui.broadcast_changes()

76e55e1

FabienLelaquais added 5 commits June 29, 2024 16:56

Fix tests

83bb06c

Spelling

34aa754

Fix mypy

b6986b8

Update doc examples

be06e07

Linter

83830d9

FabienLelaquais requested review from FabienLelaquais and removed request for FabienLelaquais June 30, 2024 17:37

More linters

8bd6bb0

FredLL-Avaiga commented Jun 30, 2024

View reviewed changes

FabienLelaquais previously approved these changes Jun 30, 2024

View reviewed changes

Fix tests and make linters even more happy

0aa3985

FabienLelaquais dismissed their stale review via 0aa3985 June 30, 2024 19:39

FabienLelaquais added 2 commits June 30, 2024 21:51

Fix test [2]

92d06c4

Re-re-re-re-re-fix tests

2c7265a

FabienLelaquais self-requested a review June 30, 2024 20:17

FabienLelaquais previously approved these changes Jun 30, 2024

View reviewed changes

namnguyen20999 previously approved these changes Jul 1, 2024

View reviewed changes

dinhlongviolin1 previously approved these changes Jul 1, 2024

View reviewed changes

avoid impact of invoke callback on current state

2555dd8

FredLL-Avaiga dismissed stale reviews from dinhlongviolin1, namnguyen20999, and FabienLelaquais via 2555dd8 July 1, 2024 08:32

FredLL-Avaiga requested review from namnguyen20999, FabienLelaquais and dinhlongviolin1 July 1, 2024 08:32

Merge branch 'develop' into feature/#1207-broadcast-callback

9af19ae

FabienLelaquais approved these changes Jul 1, 2024

View reviewed changes

FredLL-Avaiga merged commit c9a4729 into develop Jul 1, 2024
152 of 154 checks passed

FredLL-Avaiga deleted the feature/#1207-broadcast-callback branch July 1, 2024 09:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

broadcast callback on non shared variables #1441

broadcast callback on non shared variables #1441

FredLL-Avaiga commented Jun 21, 2024 •

edited

Loading

github-actions bot commented Jun 21, 2024 •

edited

Loading

FabienLelaquais commented Jun 21, 2024

dinhlongviolin1 commented Jun 22, 2024

FredLL-Avaiga commented Jun 22, 2024

FabienLelaquais left a comment

github-actions bot commented Jun 24, 2024 •

edited

Loading

FredLL-Avaiga commented Jun 25, 2024

FredLL-Avaiga commented Jun 25, 2024

FabienLelaquais commented Jun 25, 2024

github-actions bot commented Jun 29, 2024

FredLL-Avaiga left a comment

FabienLelaquais left a comment

FabienLelaquais left a comment

namnguyen20999 left a comment

dinhlongviolin1 left a comment

FabienLelaquais left a comment

broadcast callback on non shared variables #1441

broadcast callback on non shared variables #1441

Conversation

FredLL-Avaiga commented Jun 21, 2024 • edited Loading

github-actions bot commented Jun 21, 2024 • edited Loading

Coverage report for frontend/taipy-gui

Test suite run success

FabienLelaquais commented Jun 21, 2024

dinhlongviolin1 commented Jun 22, 2024

FredLL-Avaiga commented Jun 22, 2024

FabienLelaquais left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 24, 2024 • edited Loading

☂️ Python Coverage

Overall Coverage

New Files

Modified Files

FredLL-Avaiga commented Jun 25, 2024

FredLL-Avaiga commented Jun 25, 2024

FabienLelaquais commented Jun 25, 2024

github-actions bot commented Jun 29, 2024

Coverage report for ./frontend/taipy-gui

Test suite run success

FredLL-Avaiga left a comment

Choose a reason for hiding this comment

FabienLelaquais left a comment

Choose a reason for hiding this comment

FabienLelaquais left a comment

Choose a reason for hiding this comment

namnguyen20999 left a comment

Choose a reason for hiding this comment

dinhlongviolin1 left a comment

Choose a reason for hiding this comment

FabienLelaquais left a comment

Choose a reason for hiding this comment

FredLL-Avaiga commented Jun 21, 2024 •

edited

Loading

github-actions bot commented Jun 21, 2024 •

edited

Loading

Coverage report for `frontend/taipy-gui`

github-actions bot commented Jun 24, 2024 •

edited

Loading

Coverage report for `./frontend/taipy-gui`