-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove SQL repository #1555
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! a friendly note that some of the changes should be applied to enterprise repo as well :D
I forgot but do check taipy-config as well to see if there's any removals to be done |
The code coverage of |
I've checked config, theres no direct reference to sql repo, only the repository attributes(type, properties), we should be good. I'll check enterprise if theres anything to be done. |
241ff79
I've added specif tests for the base_model class. There are 2 abstract methods still not covered, but they don't have any logic to be tested. So this should be enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. Thank you Joao
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As people were saying in the 50's:
"Rock-and-roll"...
60adf5d
bbb4d08
to
60adf5d
Compare
No description provided.