Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove SQL repository #1555

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

joaoandre-avaiga
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Jul 19, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18934 16034 85% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/core/_entity/_migrate/init.py 100% 🟢
taipy/core/_entity/_migrate_cli.py 94% 🟢
taipy/core/_repository/_base_taipy_model.py 93% 🟢
taipy/core/_version/_version_manager_factory.py 89% 🟢
taipy/core/_version/_version_model.py 93% 🟢
taipy/core/cycle/_cycle_manager_factory.py 89% 🟢
taipy/core/cycle/_cycle_model.py 95% 🟢
taipy/core/data/_data_manager_factory.py 89% 🟢
taipy/core/data/_data_model.py 96% 🟢
taipy/core/job/_job_manager_factory.py 89% 🟢
taipy/core/job/_job_model.py 95% 🟢
taipy/core/scenario/_scenario_manager_factory.py 89% 🟢
taipy/core/scenario/_scenario_model.py 96% 🟢
taipy/core/submission/_submission_manager_factory.py 89% 🟢
taipy/core/submission/_submission_model.py 96% 🟢
taipy/core/task/_task_manager_factory.py 89% 🟢
taipy/core/task/_task_model.py 95% 🟢
TOTAL 93% 🟢

updated for commit: 60adf5d by action🐍

toan-quach
toan-quach previously approved these changes Jul 19, 2024
Copy link
Member

@toan-quach toan-quach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! a friendly note that some of the changes should be applied to enterprise repo as well :D

@toan-quach
Copy link
Member

I forgot but do check taipy-config as well to see if there's any removals to be done

@jrobinAV
Copy link
Member

The code coverage of taipy/core/_repository/_base_taipy_model.py is slightly low. Can you check if we can improve the coverage of this class?

jrobinAV
jrobinAV previously approved these changes Jul 19, 2024
@joaoandre-avaiga
Copy link
Collaborator Author

I forgot but do check taipy-config as well to see if there's any removals to be done

I've checked config, theres no direct reference to sql repo, only the repository attributes(type, properties), we should be good. I'll check enterprise if theres anything to be done.

@joaoandre-avaiga
Copy link
Collaborator Author

The code coverage of taipy/core/_repository/_base_taipy_model.py is slightly low. Can you check if we can improve the coverage of this class?

I've added specif tests for the base_model class. There are 2 abstract methods still not covered, but they don't have any logic to be tested. So this should be enough.

trgiangdo
trgiangdo previously approved these changes Jul 22, 2024
Copy link
Member

@trgiangdo trgiangdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Thank you Joao

jrobinAV
jrobinAV previously approved these changes Jul 22, 2024
Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As people were saying in the 50's:
"Rock-and-roll"...

@joaoandre-avaiga joaoandre-avaiga merged commit 929b7c7 into develop Jul 25, 2024
156 checks passed
@joaoandre-avaiga joaoandre-avaiga deleted the feature/remove-sql-repository branch July 25, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core: Repository Core Related to Taipy Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants