Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Spinner from rotating when hidden. #150

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Stop Spinner from rotating when hidden. #150

merged 1 commit into from
Jan 29, 2022

Conversation

dylanlangston
Copy link
Contributor

@dylanlangston dylanlangston commented Jan 28, 2022

Seems the currently used style does not stop the Rotator#PART_Rotator from rotating when IsIndeterminate="True". Found this using GPU resources in the background despite not being on screen. This fixes that by updating that current animation to override the Speed property for the entire duration of animation, forever.

Seems the currently style does not stop the Rotator#PART_Rotator from rotating when IsIndeterminate="True". Not this using GPU resources in the background despite not being on screen. This fixes that by updating that current animation to override the Speed property for the entire duration of animation, forever.
@appleneko2001
Copy link
Collaborator

appleneko2001 commented Jan 29, 2022

This fix wont stops rotator control, it still calls OnSpeedChanged method. Good for try though.
I will do some improvements for it later.

image

Anyway, thanks for your try and PR!

@appleneko2001 appleneko2001 merged commit 63854cf into AvaloniaCommunity:dev Jan 29, 2022
@dylanlangston dylanlangston deleted the patch-1 branch January 29, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants