Added theme colors demo page #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SKProCH
requested changes
Jul 31, 2023
There was a problem hiding this comment.
Can you please revert only-formatting changes for files without actual code changes? I don't sure what current formatting rules are the best and it probably should be adjusted. There is also a lot of refactoring fixes should be done before whole solution reformat.
As for adding theme colors page and csproj refactoring and other changes - its lgtm. Thanks ❤️
|
No problem, will revert them |
|
Is it fine now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added page displaying available colors palette because it was nowhere to find how these colors look like. Besides that, I've made changes to project files to align them together, by adding Directory.Build.props file with common properties and make maintenance easier. I've also updated editorconfig to mirror how code actually looks like now and linked it to all projects to be really used by IDE and formatted with it all files. XAML files were formatted with XamlStyler, which is perfect for this task and for that reason there is Settings.XamlStyler file in solution. .gitignore was also updated with newest rules. There is no reason not to use latest C# version, so now it it set in Directory.Build.props file. If you got any questions I'm eager to answer them