Feature: BrushRoundConverter supports ImmutableSolidColorBrush objects #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are used for the named colors in Avalonia
|
Hmm, actually this converters are not meant to be used in user apps... But anyway - good PR. |
|
Thanks! I wasn't using the converter directly. I set the foreground of a button to "Salmon" and noticed the hover effect stopped working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are used for the named colors built into Avalonia
Legal
I am contributing this on behalf of Garmin ©. Our legal team needs me to disclose that we are contributing this code under the MIT license that this project used at the time of contribution.