Make binding to ItemsControl.Items a compile error.
#11008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on kekekeks/XamlX#85: this PR disallows invoking "collection behavior" for property setters when using attribute syntax. Required adding a `Flyout.FlyoutPresenterClasses` setter. This property was previously buggy without the setter (see #10946 (comment)). Added tests for setting classes that I put in place when investigating this. Fixes #10946
grokys
changed the title
ItemsControl.Items.ItemsControl.Items a compile error.
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes the behavior described in #10946 whereby using
<ItemsControl Items="{Binding Foo}"would result in aBindingobject being added to theItemsControl.Itemscollection instead of resulting in a compile error.Depends on kekekeks/XamlX#85: this PR disallows invoking "collection behavior" for property setters when using attribute syntax.
Required adding a
Flyout.FlyoutPresenterClassessetter. This property was previously buggy without the setter (see #10946 (comment)). Added tests for setting classes that I put in place when investigating this.Breaking changes
Can no longer add items to a collection in XAML using attribute syntax. This shouldn't have been possible before, but it's possible that someone was depending on it working.
Fixed issues
Fixes #10946