The Great Interface Removal Part I #9553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`IAvaloniaObject`, `IControl`, `ILayoutable`, `IPanel`, `IStyledElement`, `IVisual`.
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
grokys
added a commit
that referenced
this pull request
Nov 29, 2022
…on-handler fix logic that was broken accidentally in #9553
|
I have a question. How is it possible to assign StyleKey if IStyleable is going to be removed? |
|
@rabbitism it was discussed in the #9495 |
This was referenced Jan 10, 2023
grokys
added a commit
that referenced
this pull request
May 15, 2023
This was signalled for removal in #9553, but I was hesitant to do it because it will be in use by a lot of code in order to override `StyleKey`. Instead of removing it, deprecate it and provide a virtual `StyledElement.StyleKeyOverride` property as the supported way of overriding a control's style key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
As discussed in #9495, removes a bunch of unneeded interfaces; the concrete classes should be used from this point on:
IAvaloniaObject->AvaloniaObjectIControl->ControlIInteractive->InteractiveILayoutable->LayoutableIPanel->PanelIStyledElement->StyledElementITemplatedControl->TemplatedControlIVisual->VisualIn a few cases, the interfaces were used to hide less commonly needed functionality, e.g.
IVisual.VisualRoot: the extension methods should be used, e.g.control.GetVisualRoot().Doesn't remove
IStyleableyet, that will come in a later PR (perhaps some other interfaces can be removed too).Breaking changes
Yes :)
Fixed issues
Fixes #9495