Enable building Debian package via Docker #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, if the initialization of the service fails, the lock file was not removed and thus a second attempt to start detd fails. This is fixed by catching the exception and cleaning up the lock file. Signed-off-by: Florian Kauer <[email protected]>
This creates the directory for the socket file if it does not yet exists. Signed-off-by: Florian Kauer <[email protected]>
Currently, even when an error occurs, the package_debian.sh runs until completion and falsely reports a success. By adding set -e this can be avoided. Signed-off-by: Florian Kauer <[email protected]>
The current package_debian.sh circumvents to print the full filename of the Debian package by using wildcards. However, this is not very user-friendly and can lead to confusion or bugs. Especially when you do a remote or Docker build, the filename should be explictly printed, otherwise it can be difficult to find the result. Therefore, assemble the full filename. Signed-off-by: Florian Kauer <[email protected]>
override_dh_systemd_start is deprecated and thus it does no longer build successfully in Debian Bookworm. Replace it with override_dh_installsystemd. Signed-off-by: Florian Kauer <[email protected]>
To enable building for other distributions or without installing the build dependencies locally, provide a Dockerfile and the corresponding usage guide. Signed-off-by: Florian Kauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable building for other distributions or without
installing the build dependencies locally, provide a
Dockerfile and the corresponding usage guide.
Also fix a few issues with the current Debian build script.