-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Core} Bump MSAL to 1.28.1 and PyMSALRuntime to 0.16.2 #29088
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Core |
@@ -120,7 +120,7 @@ pycomposefile==0.0.30 | |||
pycparser==2.19 | |||
PyGithub==1.55 | |||
PyJWT==2.4.0 | |||
pymsalruntime==0.14.2a1 | |||
pymsalruntime==0.16.2a1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no PyMSALRuntime 0.15.0, 0.16.0 or 0.16.1:
https://pypi.org/project/pymsalruntime/#history
This is because the fix for User cancelled the Accounts Control Operation
is only in MSALRuntime 0.16.2. Backporting the fix to 0.14.2 is throw-away work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backporting the fix to 0.14.2 is throw-away work.
FYI: Actually, that was our preferred approach. We (MsalRuntime and Msal Python team) attempted that, but encountered technical difficulties, so we settled with 0.16.2 this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use the word "throw-away" because users tend to use a newer version when available.
Related command
az login
Description
Fix #28997
Bump PyMSALRuntime to 0.16.2 to solve #28997. Bump MSAL to 1.28.1 to allow PyMSALRuntime 0.16.2: AzureAD/microsoft-authentication-library-for-python@ddb94b2
Testing Guide
Open Windows Terminal as administrator, run
History Notes
[Core] Fix #28997: Fix error "User cancelled the Accounts Control Operation" when logging in with WAM as Administrator