-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] BREAKING CHANGE: Fix #29379: az aks create
: Fix option --cluster-autoscaler-profile
to accept space separated values
#29429
Open
FumingZhang
wants to merge
3
commits into
Azure:dev
Choose a base branch
from
FumingZhang:fuming/cap-fix1-0719
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
AKS |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
July 19, 2024 09:37
microsoft-github-policy-service
bot
added
Auto-Assign
Auto assign by bot
AKS
az aks/acs/openshift
labels
Jul 19, 2024
FumingZhang
changed the title
[AKS]
[AKS] Fix #29379: Jul 19, 2024
az aks create
: Update option --cluster-autoscaler-profile
az aks create
: Update option --cluster-autoscaler-profile
FumingZhang
force-pushed
the
fuming/cap-fix1-0719
branch
from
July 22, 2024 08:50
eb6bc6f
to
8fcb94d
Compare
3 tasks
please rerun related tests to verify if the changes meet your expectations. |
Queued live test to validate the change, test passed!
|
FumingZhang
changed the title
[AKS] Fix #29379:
[AKS] Fix #29379: Jul 26, 2024
az aks create
: Update option --cluster-autoscaler-profile
az aks create
: Fix option --cluster-autoscaler-profile
to accept space separated values
FumingZhang
changed the title
[AKS] Fix #29379:
[AKS] BREAKING CHANGE: Fix #29379: Jul 29, 2024
az aks create
: Fix option --cluster-autoscaler-profile
to accept space separated valuesaz aks create
: Fix option --cluster-autoscaler-profile
to accept space separated values
Synced with feature owner, decided to make the change during the next breaking change window. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks create
Description
[AKS] BREAKING CHANGE: Fix #29379:
az aks create
: Fix option--cluster-autoscaler-profile
to accept space separated valuesSpecify multiple values for the same key by separating them with commas. For different key-value pairs, separated by space.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a
: Make some customer-facing breaking change[Component Name 2]
az command b
: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.