[BREAKING CHANGE] az role assignment list: Drop --include-classic-administrators argument
#29470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌AzureCLI-FullTest
|
|
Hi @jiasli, |
❌AzureCLI-BreakingChangeTest
|
|
BREAKING CHANGE |
|
Sample classic admins returned by {
"id": "NA(classic admins)",
"name": "NA(classic admins)",
"principalId": "00000000-0000-0000-0000-000000000000",
"principalName": "[email protected]",
"roleDefinitionId": "NA(classic admin role)",
"roleDefinitionName": "ServiceAdministrator;AccountAdministrator",
"scope": "/subscriptions/00000000-0000-0000-0000-000000000000"
},
{
"id": "NA(classic admins)",
"name": "NA(classic admins)",
"principalId": "00000000-0000-0000-0000-000000000000",
"principalName": "[email protected]",
"roleDefinitionId": "NA(classic admin role)",
"roleDefinitionName": "CoAdministrator",
"scope": "/subscriptions/00000000-0000-0000-0000-000000000000"
}, |
jiasli
commented
Aug 2, 2024
| @@ -442,53 +431,6 @@ def list_role_assignment_change_logs(cmd, start_time=None, end_time=None): # py | |||
| return result | |||
|
|
|||
|
|
|||
| def _backfill_assignments_for_co_admins(cli_ctx, auth_client, assignee=None): | |||
| worker = MultiAPIAdaptor(cli_ctx) | |||
| co_admins = auth_client.classic_administrators.list() # known swagger bug on api-version handling | |||
There was a problem hiding this comment.
I don't know what the bug is.
jiasli
requested review from
jsntcy,
kairu-ms,
zhoxing-ms and
necusjz
as code owners
|
According to https://learn.microsoft.com/en-us/azure/role-based-access-control/classic-administrators, the full deprecation of classic admins has been extended to April 3, 2024. Putting this PR into backlog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az role assignment listDescription
Close #27199
#29404 added deprecation message for
--include-classic-administrators. This PR drops--include-classic-administratorsargument.Testing Guide