-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] az storage fs directory upload/download
, az storage blob sync
: Add back --auth-mode login
as AzCopy supports Oauth now
#29487
Merged
calvinhzy
merged 7 commits into
Azure:dev
from
calvinhzy:fix-storage-blob-sync-auth-mode-login
Jul 30, 2024
Merged
[Storage] az storage fs directory upload/download
, az storage blob sync
: Add back --auth-mode login
as AzCopy supports Oauth now
#29487
calvinhzy
merged 7 commits into
Azure:dev
from
calvinhzy:fix-storage-blob-sync-auth-mode-login
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AzCopy supports Oauth now, tested
️✔️AzureCLI-FullTest
|
Hi @calvinhzy, |
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
storage blob sync | cmd storage blob sync added parameter auth_mode |
||
storage blob sync | cmd storage blob sync added parameter extra_options |
||
storage blob sync | cmd storage blob sync update parameter extra_options : removed property nargs=* |
||
storage blob sync | cmd storage blob sync update parameter extra_options : updated property name from extra_options to account_name |
||
storage blob sync | cmd storage blob sync update parameter extra_options : updated property options from [] to ['--account-name'] |
||
storage fs directory download | cmd storage fs directory download added parameter auth_mode |
||
storage fs directory upload | cmd storage fs directory upload added parameter auth_mode |
Storage |
calvinhzy
changed the title
[Storage]
[Storage] Jul 27, 2024
az storage fs directory upload/download
: Add back --auth-mode login
as AzCopy supports Oauth nowaz storage fs directory upload/download
, az storage blob sync
: Add back --auth-mode login
as AzCopy supports Oauth now
calvinhzy
requested review from
jsntcy,
zhoxing-ms,
jiasli,
kairu-ms and
wangzelin007
as code owners
July 30, 2024 07:00
evelyn-ys
reviewed
Jul 30, 2024
evelyn-ys
reviewed
Jul 30, 2024
evelyn-ys
approved these changes
Jul 30, 2024
kairu-ms
approved these changes
Jul 30, 2024
wangzelin007
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
az storage fs directory upload/download
Fix #28749 Fix #29322 Fix #20488az storage blob sync
Fix #26717 Fix #29365Testing Guide
History Notes
[Storage]
az storage fs directory upload/download
: Add back--auth-mode login
as AzCopy supports Oauth now[Storage]
az storage blob sync
: Add back--auth-mode login
as AzCopy supports Oauth nowThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.