[MySQL] az mysql flexible-server maintenance: New command group for managing maintenance of MySQL flexible server
#29505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔄AzureCLI-FullTest
|
|
Hi @Xiaoy666, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| mysql flexible-server maintenance | sub group mysql flexible-server maintenance added |
|
MySQL |
|
@microsoft-github-policy-service agree company="Microsoft" |
evelyn-ys
changed the title
az mysql flexible-server maintenance command group for managing maintenance of MySQL flexible serveraz mysql flexible-server maintenance: New command group for managing maintenance of MySQL flexible server
honghr
approved these changes
Aug 1, 2024
| with self.argument_context('mysql flexible-server maintenance reschedule') as c: | ||
| c.argument('resource_group_name', arg_type=resource_group_name_type, help='Resource Group Name of the server.') | ||
| c.argument('server_name', options_list=['--server-name', '-s'], help='The name of the server.') | ||
| c.argument('maintenance_name', options_list=['--maintenance-name', '-m'], help='The name of the maintenance.') |
| c.argument('resource_group_name', arg_type=resource_group_name_type, help='Resource Group Name of the server.') | ||
| c.argument('server_name', options_list=['--server-name', '-s'], help='The name of the server.') | ||
| c.argument('maintenance_name', options_list=['--maintenance-name', '-m'], help='The name of the maintenance.') | ||
| c.argument('maintenance_start_time', arg_type=maintenance_reschedule_time_arg_type, help='The new start time of the rescheduled maintenance.') |
There was a problem hiding this comment.
We may need add validator for date format. If cannot add here, please add to custom.py
| @@ -588,6 +595,21 @@ def load_arguments(self, _): # pylint: disable=too-many-statements, too-many- | |||
| with self.argument_context('mysql flexible-server identity show') as c: | |||
| c.argument('identity', options_list=['--identity', '-n'], help='Name or ID of identity to show.', validator=validate_identity) | |||
|
|
|||
| with self.argument_context('mysql flexible-server maintenance reschedule') as c: | |||
| c.argument('resource_group_name', arg_type=resource_group_name_type, help='Resource Group Name of the server.') | |||
| c.argument('server_name', options_list=['--server-name', '-s'], help='The name of the server.') | |||
There was a problem hiding this comment.
If we don't need to check other attributes for server besides existence, I think we can skip server name validate here and make sure backend will check.
evelyn-ys
reviewed
Aug 20, 2024
Comment on lines
+1194
to
+1199
| def flexible_server_maintenance_list(client, resource_group_name, server_name): | ||
| return client.list(resource_group_name=resource_group_name, server_name=server_name) | ||
|
|
||
|
|
||
| def flexible_server_maintenance_show(client, resource_group_name, server_name, maintenance_name): | ||
| return client.read(resource_group_name=resource_group_name, server_name=server_name, maintenance_name=maintenance_name) |
There was a problem hiding this comment.
If there's no custom logic, you don't need to define custom_command with custom func, just use command to call SDK function directly
evelyn-ys
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az mysql flexible-server maintenance show
az mysql flexible-server maintenance list
az mysql flexible-server maintenance reschedule
Description
Add az command group 'az mysql flexible-server maintenance' which contains above three az commands. These commands will support customers to manage their maintenance on Azure MySQL flexible servers.
Testing Guide
az mysql flexible-server maintenance show --resource-group testgroup --server-name testserver --maintenance-name _T9Q-TS8explanation: Get a maintenance of mysql flexible server 'testserver' under resource group 'testgroup', with maintenance name '_T9Q-TS8'
az mysql flexible-server maintenance list --resource-group testgroup --server-name testserverexplanation: List all of the maintenances of mysql flexible server 'testserver' under resource group 'testgroup'.
az mysql flexible-server maintenance reschedule --resource-group testgroup --server-name testserver --maintenance-name _T9Q-TS8 --start-time 2024-06-01T09:00:00Zexplanation: reschedule an existing maintenance '_T9Q-TS8' of the server 'testserver' under resource gruop 'testgroup' to a new start time 'UTC 20240601