[Backup] backup restore restore-disks: Add support for enabling Disk access settings for managed VM restores
#29508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @zubairabid, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| backup restore restore-disks | cmd backup restore restore-disks added parameter disk_access_option |
||
| backup restore restore-disks | cmd backup restore restore-disks added parameter target_disk_access_id |
|
Backup |
microsoft-github-policy-service
bot
requested review from
yonzhan and
wangzelin007
|
Requesting a review for this release cycle (subject to merge validation). |
|
Please fix CI issues |
zhoxing-ms
reviewed
Aug 26, 2024
Comment on lines
+403
to
+404
| c.argument('disk_access_option', arg_type=get_enum_type(allowed_disk_access_options), help='Specifies the disk access option for target disks.') | ||
| c.argument('target_disk_access_id', help='Specifies the target disk access ID when --disk-access-option is set to EnablePrivateAccessForAllDisks') |
There was a problem hiding this comment.
Please use the first person voice in the help message
Suggested change
| c.argument('disk_access_option', arg_type=get_enum_type(allowed_disk_access_options), help='Specifies the disk access option for target disks.') | |
| c.argument('target_disk_access_id', help='Specifies the target disk access ID when --disk-access-option is set to EnablePrivateAccessForAllDisks') | |
| c.argument('disk_access_option', arg_type=get_enum_type(allowed_disk_access_options), help='Specify the disk access option for target disks.') | |
| c.argument('target_disk_access_id', help='Specify the target disk access ID when --disk-access-option is set to EnablePrivateAccessForAllDisks') |
zhoxing-ms
changed the title
zhoxing-ms
changed the title
backup restore restore-disks: Add support for enabling Disk access settings for managed VM restores
|
@zubairabid Please add some test cases for these new parameters |
|
Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 10-08) |
zhoxing-ms
modified the milestones:
August 2024 (2024-09-03),
September 2024 (2024-10-08)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az backup restore restore-disksDescription
Some managed VMs have disks with PE enabled (they have some Disk Access associated). We can now use Enhanced Policy to back them up. During restore, we have the option of allowing public access, specifying a new disk access, or specifying PE with the same disk access. We have added changes that allow for this.
Testing Guide
History Notes
[Backup] Added support for enabling Disk access settings for managed VM restores[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.