[App Service] az staticwebapp create and az staticwebapp update: Add Dedicated as supported SKU
#29514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joslinmicrosoft
requested review from
jsntcy,
zhoxing-ms and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @joslinmicrosoft, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| staticwebapp create | cmd staticwebapp create update parameter sku: updated property choices from ['Free', 'Standard'] to ['Dedicated', 'Free', 'Standard'] |
||
| staticwebapp update | cmd staticwebapp update update parameter sku: updated property choices from ['Free', 'Standard'] to ['Dedicated', 'Free', 'Standard'] |
|
App Service |
|
Hi @jsntcy @zhoxing-ms @yanzhudd could I please get a review on this change and your help getting it merged? Thank you! |
|
Hi @jsntcy @zhoxing-ms @yanzhudd, any updates here? Could you please help get this PR merged? |
zhoxing-ms
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az staticwebapp createaz staticwebapp updateDescription
For Static Web Apps, we have recently previewed the Dedicated SKU. Currently, the related staticwebapp commands only support Free and Standard SKU. This PR adds support for the Dedicated SKU, as well as adds it to supported features in help texts.
Testing Guide
Added and ran a new unit test
test_create_staticapp_with_dedicated_sku.Also ran the following command (with actual values in place of sample values) with this code and verified a Dedicated SKU Static Web App was successfully created:
az staticwebapp create -n name1 -g rg1 -s https://github.com/Contoso/My-First-Static-App -b dev -l EastUs2 --app-location app --sku DedicatedHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.