-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Packaging} Add warning message for Alpine-based image #29628
Conversation
Hi @jiasli, |
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Add global warning message to drive the transition to Azure Linux based image |
"Azure CLI v2.63 is the latest version available on Alpine 10 and will not receive updates. " | ||
"Consider migrating to the Azure Linux based image for Azure CLI. " | ||
"For more information: https://docs.microsoft.com/..." | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GitHub actions users will see this warning. We'd better to add the instruction to hide the warning.
azure/cli
actions also need to migrate to Azure Linux based image in the future.
@MoChilia
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
az config set core.only_show_errors=true
can control this message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to use az config
to hide this warning message, but it may also hide other warnings. I will first migrate azure/cli action to use Mariner-based image to avoid this warning and ensure the latest azure-cli is available in azure/cli action. Later we may migrate to Azure Linux based image once it's ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to use
az config
to hide this warning message, but it may also hide other warnings.
I think this is acceptable. I don't want to spend too much effort on this warning message as Alpine-based images will no longer be released/maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiasli, isn't it just Alpine
and not Alpine 10
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no “alpine 10”.
PS: There is Alpine 3.10. But we’re using 3.20 now. I think we can omit the version number in warning message.
src/azure-cli/azure/cli/__main__.py
Outdated
ALPINE_WARNING_MESSAGE = ( | ||
"Azure CLI v2.63 is the latest version available on Alpine 10 and will not receive updates. " | ||
"Consider migrating to the Azure Linux based image for Azure CLI. " | ||
"For more information: https://docs.microsoft.com/..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is pending MicrosoftDocs/azure-docs-cli#4480.
fa17d07
to
01ea4a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add global warning message to drive the transition to Azure Linux based image.