Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing redefining of msbuild target _FunctionsPreBuild #2498

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented May 30, 2024

The _FunctionsPreBuild msbuild target is currently being redefined, which will cause msbuild to ignore the first one.

The change (with redefinition) was introduced in #2347

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

The `_FunctionsPreBuild` msbuild target is currently being redefined.
@kshyju kshyju merged commit 071d102 into main May 30, 2024
21 checks passed
@kshyju kshyju deleted the shkr/net9_sdk branch May 30, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants