Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClient - Proxy planner support #370

Merged
merged 8 commits into from
Aug 26, 2024
Merged

HttpClient - Proxy planner support #370

merged 8 commits into from
Aug 26, 2024

Conversation

ohadbitt
Copy link
Collaborator

Added

  • Proxy planner support for http client

@ohadbitt ohadbitt requested a review from AsafMah July 21, 2024 11:25
@github-actions GitHub Actions
Copy link

Test Results

322 tests  +1   314 ✅ +1   3m 15s ⏱️ -46s
 26 suites +1     8 💤 ±0 
 26 files   +1     0 ❌ ±0 

Results for commit 1802098. ± Comparison against base commit 3773431.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 21, 2024 •
edited
Loading

Test Results

322 tests  +1   314 ✅ +1   2m 42s ⏱️ +22s
 25 suites ±0     8 💤 ±0 
 25 files   ±0     0 ❌ ±0 

Results for commit 776d4b2. ± Comparison against base commit 0ec574d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Test Results

322 tests  +1   314 ✅ +1   3m 14s ⏱️ -47s
 26 suites +1     8 💤 ±0 
 26 files   +1     0 ❌ ±0 

Results for commit 1802098. ± Comparison against base commit 3773431.

@ohadbitt ohadbitt mentioned this pull request Jul 30, 2024
Open
AsafMah
AsafMah requested changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@AsafMah AsafMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the changelog

data/src/main/java/com/microsoft/azure/kusto/data/http/SimpleProxyPlanner.java Outdated Show resolved Hide resolved
AsafMah
AsafMah approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@AsafMah AsafMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

ingest/src/test/java/com/microsoft/azure/kusto/ingest/E2ETest.java Show resolved Hide resolved
ingest/src/test/java/com/microsoft/azure/kusto/ingest/E2ETest.java Show resolved Hide resolved
@ohadbitt ohadbitt merged commit 9ff0fb7 into master Aug 26, 2024
8 checks passed
@ohadbitt ohadbitt deleted the proxy-nonHost branch August 26, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsafMah AsafMah AsafMah approved these changes

Assignees

@ohadbitt ohadbitt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ohadbitt @AsafMah @ohbitton