Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop tests from depending on table row store being sealed #380

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

yihezkel
Copy link
Member

@yihezkel yihezkel commented Aug 4, 2024

Changed

Stop tests from depending on table row store being sealed, to shorten E2E runtime, and prevent timeouts even with the new HTTP client.

… E2E runtime, and prevent timeouts even with the new HTTP client.
Copy link

github-actions bot commented Aug 4, 2024

Test Results

321 tests  ±0   313 ✅ ±0   3m 7s ⏱️ - 1m 14s
 25 suites ±0     8 💤 ±0 
 25 files   ±0     0 ❌ ±0 

Results for commit f926e07. ± Comparison against base commit 25af8f9.

♻️ This comment has been updated with latest results.

@AsafMah
Copy link
Contributor

AsafMah commented Aug 5, 2024

In a lot of other places in the SDK and others, we run a ".clear database cache streamingingestion schema"

Could it work for this case?

@yihezkel
Copy link
Member Author

yihezkel commented Aug 6, 2024

In a lot of other places in the SDK and others, we run a ".clear database cache streamingingestion schema"

Could it work for this case?

Valentina said that command wouldn't help

@yihezkel yihezkel merged commit 723e09e into master Aug 7, 2024
8 checks passed
@yihezkel yihezkel deleted the skipSealDuringTearDown branch August 7, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants