Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Security to add version preview/2023-05-01-preview #24090

Closed
wants to merge 34 commits into from

remove parent scope

c89cc00
Select commit
Loading
Failed to load commit list.
Closed

[Hub Generated] Review request for Microsoft.Security to add version preview/2023-05-01-preview #24090

remove parent scope
c89cc00
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
openapi-pipeline-app / Swagger LintDiff failed May 31, 2023 in 3m 29s

Swagger LintDiff failed

LintDiff: 11 Errors, 33 Warnings
View more details on Swagger Pipeline

Details

compared tags (via openapi-validator v2.1.2) new version base version
package-composite-v3 package-composite-v3(c89cc00) package-composite-v3(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ NoDuplicatePathsForScopeParameter Path '/{scope}/providers/Microsoft.Security/customRecommendations/{customRecommendationName}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Security/customRecommendations' that has the scope parameter.'.
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L37		 RPC-Uri-V1-10
❌ DeleteOperationAsyncResponseValidation An async DELETE operation must return 202.
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L206		 RPC-Async-V1-09
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L216
❌ TopLevelResourcesListBySubscription The top-level resource 'CustomRecommendation' does not have list by subscription operation, please add it.
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L246		 RPC-Get-V1-05
❌ NoDuplicatePathsForScopeParameter Path '/{scope}/providers/Microsoft.Security/securityStandards/{standardId}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Security/securityStandards' that has the scope parameter.'.
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L37		 RPC-Uri-V1-10
❌ DeleteOperationAsyncResponseValidation An async DELETE operation must return 202.
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L206		 RPC-Async-V1-09
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L216
❌ TopLevelResourcesListBySubscription The top-level resource 'SecurityStandard' does not have list by subscription operation, please add it.
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L247		 RPC-Get-V1-05
❌ ParametersOrder The parameters:standardAssignmentName,resourceId should be kept in the same order as they present in the path.
Location: Microsoft.Security/preview/2023-05-01-preview/standardAssignments.json#L126
❌ NoDuplicatePathsForScopeParameter Path '/{resourceId}/providers/Microsoft.Security/standardAssignments/{standardAssignmentName}' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Security/standardAssignments' that has the scope parameter.'.
Location: Microsoft.Security/preview/2023-05-01-preview/standardAssignments.json#L165		 RPC-Uri-V1-10
❌ TopLevelResourcesListBySubscription The top-level resource 'StandardAssignment' does not have list by subscription operation, please add it.
Location: Microsoft.Security/preview/2023-05-01-preview/standardAssignments.json#L225		 RPC-Get-V1-05
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L55
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'scope'.
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L55
⚠️ RequiredReadOnlySystemData The response of operation:'CustomRecommendations_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L83
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L100
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'scope'.
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L100
⚠️ RequiredReadOnlySystemData The response of operation:'CustomRecommendations_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L126
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L143
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'scope'.
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L143
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L195
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'scope'.
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L195
⚠️ ProvisioningStateSpecifiedForLRODelete 200 response schema in long running DELETE operation is missing ProvisioningState property. A LRO DELETE operations 200 response schema must have ProvisioningState specified.
Location: Microsoft.Security/preview/2023-05-01-preview/customRecommedations.json#L207
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L55
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'scope'.
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L55
⚠️ RequiredReadOnlySystemData The response of operation:'SecurityStandards_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L83
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L100
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'scope'.
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L100
⚠️ RequiredReadOnlySystemData The response of operation:'SecurityStandards_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L126
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L143
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'scope'.
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L143
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L195
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'scope'.
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L195
⚠️ ProvisioningStateSpecifiedForLRODelete 200 response schema in long running DELETE operation is missing ProvisioningState property. A LRO DELETE operations 200 response schema must have ProvisioningState specified.
Location: Microsoft.Security/preview/2023-05-01-preview/securityStandards.json#L207
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-05-01-preview/standardAssignments.json#L50
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'scope'.
Location: Microsoft.Security/preview/2023-05-01-preview/standardAssignments.json#L50
⚠️ RequiredReadOnlySystemData The response of operation:'StandardAssignments_Create' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Security/preview/2023-05-01-preview/standardAssignments.json#L76
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-05-01-preview/standardAssignments.json#L91
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'scope'.
Location: Microsoft.Security/preview/2023-05-01-preview/standardAssignments.json#L91
⚠️ RequiredReadOnlySystemData The response of operation:'StandardAssignments_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Security/preview/2023-05-01-preview/standardAssignments.json#L126
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-05-01-preview/standardAssignments.json#L138
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'scope'.
Location: Microsoft.Security/preview/2023-05-01-preview/standardAssignments.json#L138
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Security/preview/2023-05-01-preview/standardAssignments.json#L177
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'scope'.
Location: Microsoft.Security/preview/2023-05-01-preview/standardAssignments.json#L177
⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.Security/preview/2023-05-01-preview/standardAssignments.json#L283
View more details on openapi-pipeline-app