Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure VMware Solution 2023-09-01 in TypeSpec #28023

Merged
merged 32 commits into from
Mar 15, 2024

Properties of a PATCH request body must not have default value, prope…

49c09a5
Select commit
Loading
Failed to load commit list.
Merged

Azure VMware Solution 2023-09-01 in TypeSpec #28023

Properties of a PATCH request body must not have default value, prope…
49c09a5
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff failed Mar 1, 2024 in 16m 41s

Swagger LintDiff failed

LintDiff: 16 Errors, 2 Warnings
View Azure DevOps build log for more details.

Details

compared tags (via openapi-validator v2.2.0) new version base version
package-2023-09-01 package-2023-09-01(49c09a5) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L489		 RPC-Patch-V1-10
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L489		 RPC-Patch-V1-10
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1609		 RPC-Patch-V1-10
❌ EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L3190		 RPC-Put-V1-02
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L161
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L205


The following errors/warnings exist before current PR submission:

Rule Message
❌ PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L460
❌ PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L1572
❌ PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L3736
❌ PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L3798
❌ EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L4552
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:dhcpType.
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L4704
❌ EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L4864
❌ EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L5176
❌ EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L5593
❌ EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L5905
❌ EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L6142
❌ EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.AVS/stable/2023-09-01/vmware.json#L6581
View more details on openapi-pipeline-app