-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare to move ARM types to subpackages #3892
base: main
Are you sure you want to change the base?
Conversation
We think that the problem with some of the tests is this test-specific function: It needs to take a collection of packages, so that the codeGenContext has information about the imported packages too. Otherwise it can't find the arm types and fails. |
I also merged + pushed, we may need to re-record the golden file tests after my changes. |
74cd5cf
to
50ab0f1
Compare
50ab0f1
to
0c4ac0a
Compare
What this PR does / why we need it:
Moves ARM types to subpackages, subject to a deny list that maintains the status quo.
We can remove groups from the deny list gradually, allowing a step by step migration to the new structure.
Special notes for your reviewer:
Currently, unit tests fail in the
internal/codegen/pipeline
folder and I haven't been able to work out why.Adding an entry to the deny list for the group
person
makes the problem go away, so it's definitely due to these changes.How does this PR make you feel:
![gif](https://camo.githubusercontent.com/28785f879dc677a839691d30f2c7e2f0318f5bcbe8c6523801cdece83345fe8f/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f336f456a493550585152646f6c31354d48652f67697068792e6769663f6369643d37393062373631317634726f7a6e63626c76743870703870366433766274377933313566763030696471617435656f642665703d76315f676966735f736561726368267269643d67697068792e6769662663743d67)