fix AZURE_USER_AGENT_SUFFIX not getting set #4011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojnhuh
requested review from
davefellows,
theunrepentantgeek,
matthchr,
babbageclunk and
super-harsh
as code owners
|
Oh no! Thanks for the fix! |
matthchr
approved these changes
May 13, 2024
|
/ok-to-test sha=388cfcc |
super-harsh
approved these changes
May 13, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #[issue number]
What this PR does / why we need it:
The
AZURE_USER_AGENT_SUFFIXfield in the aso-controller-settings Secret added in #3650 was not being read because the controller Pod wasn't setting the environment variable for it in its definition.Special notes for your reviewer:
How does this PR make you feel:
If applicable: