ADR to add custom operatorspec properties #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
super-harsh
approved these changes
May 28, 2024
docs/hugo/content/design/ADR-2024-05-OperatorSpec-Custom-Properties/_index.md
Outdated
Show resolved
Hide resolved
matthchr
approved these changes
Jun 6, 2024
|
|
||
| * PRO: Allows multiple operator spec properties to be declared against a single resource. | ||
| * PRO: Allows for operator spec properties that aren't specific to a single property or group of properties | ||
| * CON: Doesn't make it clear which resource properties are influenced by the operator spec property. |
There was a problem hiding this comment.
I think this con is pretty mitigatable with documentation (either in the code or in the ASO YAML or both, depending on what we think makes the most sense)
…rties/_index.md Co-authored-by: Harshdeep Singh (harshdsingh) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Outlines potential approaches for adding additional properties to the
operatorSpecfor a resource, allowing additional fine control by ASO.Special notes for your reviewer:
Inspired by conversations about #3935
How does this PR make you feel:
If applicable: