Fix spec initializing copying wrong property #4108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
matthchr
approved these changes
Jun 18, 2024
| path []astmodel.PropertyName, | ||
| ) *TypedConversionEndpoint { | ||
| var builder strings.Builder | ||
| for i, name := range path { |
There was a problem hiding this comment.
minor: You could probably have used strings.Join here, though it would require transforming the path to strings first.
| // assign is a function that will be called for each matching property, with the source and destination endpoints | ||
| // for that property. | ||
| // Returns an error if any of the assignments fail. | ||
| func (builder *PropertyAssignmentFunctionBuilder) selectIdenticallyPathedProperties( |
There was a problem hiding this comment.
extremely minor:
Suggested change
| func (builder *PropertyAssignmentFunctionBuilder) selectIdenticallyPathedProperties( | |
| func (builder *PropertyAssignmentFunctionBuilder) selectPropertiesWithIdenticalPaths( |
(avoids IdenticallyPathed which read weird to me. Not sure it's really all that much better.)
theunrepentantgeek
removed this pull request from the merge queue due to a manual request
|
Seems some unit test failures @theunrepentantgeek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In #3805, @nojnhuh noticed that
asoctlwas initializing thetypefield on an imported AgentPool with the wrong value.Investigation leads to the observation that properties with the same name don't necessarily have the same providence - not every
Typefield can be copied into anotherTypefield.Special notes for your reviewer:
There are two fixes.
The first is to check the origin of each property, skipping the assign-identically-named-properties step if the properties came from different places
The second fix is to use the path-of-origin of the remaining properties to match things up. This is complicated by the possibility that the property may be configurable - so we would have both
TypeandTypeFromConfigas candidates. We disambiguate these by doing a fast and loose compatibility check on the types, which seems good enough.How does this PR make you feel:
If applicable: