-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nightly copa scan and patch workflow #1065
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1065 +/- ##
=======================================
Coverage 53.71% 53.71%
=======================================
Files 36 36
Lines 2290 2290
=======================================
Hits 1230 1230
Misses 1014 1014
Partials 46 46 |
@ashnamehrotra can you make sure to test this in your fork? |
.github/workflows/patch-images.yaml
Outdated
pull_request: | ||
branches: | ||
- main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this to be run as part of every PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't, removed!
fail-fast: false | ||
matrix: | ||
images: ['ghcr.io/azure/azure-workload-identity/proxy-init:latest-linux-arm64', 'ghcr.io/azure/azure-workload-identity/proxy-init:latest-linux-amd64'] | ||
steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the Harden runner
step
azure-workload-identity/.github/workflows/publish-images.yaml
Lines 38 to 41 in eb7cef3
- name: Harden Runner | |
uses: step-security/harden-runner@cba0d00b1fc9a034e1e642ea0f1103c282990604 # v2.5.0 | |
with: | |
egress-policy: audit |
@@ -0,0 +1,69 @@ | |||
on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a name to the workflow
run: | | ||
docker tag ghcr.io/azure/azure-workload-identity/proxy-init:patched ${{ matrix.images }} | ||
docker push ${{ matrix.images }} | ||
create-updated-manifest: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create-updated-manifest: | |
create-updated-manifest: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 minor comment, otherwise lgtm!
needs: patch | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Login to ghcr.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the Harden runner
step here too?
azure-workload-identity/.github/workflows/publish-images.yaml
Lines 38 to 41 in eb7cef3
- name: Harden Runner | |
uses: step-security/harden-runner@cba0d00b1fc9a034e1e642ea0f1103c282990604 # v2.5.0 | |
with: | |
egress-policy: audit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ashnamehrotra 🎉
LGTM!
Reason for Change:
Adds a patch workflow to run nightly using the Copa Github Action to patch ghcr.io/azure/azure-workload-identity/proxy-init:latest if there are vulnerabilities.
Requirements
Issue Fixed:
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: