Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nightly copa scan and patch workflow #1065

Merged
merged 17 commits into from
Aug 22, 2023
Merged

Conversation

ashnamehrotra
Copy link
Contributor

Reason for Change:

Adds a patch workflow to run nightly using the Copa Github Action to patch ghcr.io/azure/azure-workload-identity/proxy-init:latest if there are vulnerabilities.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Merging #1065 (e260aad) into main (a3111ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1065   +/-   ##
=======================================
  Coverage   53.71%   53.71%           
=======================================
  Files          36       36           
  Lines        2290     2290           
=======================================
  Hits         1230     1230           
  Misses       1014     1014           
  Partials       46       46           

@sozercan
Copy link
Member

@ashnamehrotra can you make sure to test this in your fork?

Comment on lines 4 to 6
pull_request:
branches:
- main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this to be run as part of every PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't, removed!

fail-fast: false
matrix:
images: ['ghcr.io/azure/azure-workload-identity/proxy-init:latest-linux-arm64', 'ghcr.io/azure/azure-workload-identity/proxy-init:latest-linux-amd64']
steps:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the Harden runner step

- name: Harden Runner
uses: step-security/harden-runner@cba0d00b1fc9a034e1e642ea0f1103c282990604 # v2.5.0
with:
egress-policy: audit

@@ -0,0 +1,69 @@
on:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a name to the workflow

run: |
docker tag ghcr.io/azure/azure-workload-identity/proxy-init:patched ${{ matrix.images }}
docker push ${{ matrix.images }}
create-updated-manifest:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
create-updated-manifest:
create-updated-manifest:

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 minor comment, otherwise lgtm!

needs: patch
runs-on: ubuntu-latest
steps:
- name: Login to ghcr.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the Harden runner step here too?

- name: Harden Runner
uses: step-security/harden-runner@cba0d00b1fc9a034e1e642ea0f1103c282990604 # v2.5.0
with:
egress-policy: audit

@sozercan sozercan requested a review from aramase August 22, 2023 17:38
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ashnamehrotra 🎉

LGTM!

@aramase aramase merged commit b68e331 into main Aug 22, 2023
12 checks passed
@aramase aramase deleted the add-copa-action-workflow branch August 22, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants