Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove err return and add unit tests for handle errors #1091

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented Aug 23, 2023

  • remove unused error in the function
  • add unit tests for webhook handler errors

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Merging #1091 (c37b659) into main (4a889b7) will increase coverage by 1.59%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
+ Coverage   53.89%   55.49%   +1.59%     
==========================================
  Files          36       36              
  Lines        2297     2294       -3     
==========================================
+ Hits         1238     1273      +35     
+ Misses       1014      980      -34     
+ Partials       45       41       -4     
Files Changed Coverage Δ
pkg/webhook/webhook.go 86.26% <100.00%> (+6.19%) ⬆️

... and 1 file with indirect coverage changes

@aramase aramase marked this pull request as ready for review August 23, 2023 23:16
@aramase aramase requested a review from enj as a code owner August 23, 2023 23:16
@aramase aramase requested a review from sozercan August 23, 2023 23:17
@aramase aramase enabled auto-merge (squash) August 23, 2023 23:17
@aramase aramase merged commit 37dc12f into Azure:main Aug 25, 2023
22 checks passed
@aramase aramase deleted the aramase/c/add_unit_tests branch August 25, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants