Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit test for proxy #1092

Merged
merged 2 commits into from
Aug 24, 2023
Merged

test: add unit test for proxy #1092

merged 2 commits into from
Aug 24, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented Aug 23, 2023

  • add unit test for NewProxy

@aramase
test: add unit test for proxy
6392bfe 
Signed-off-by: Anish Ramasekar <[email protected]>
@aramase aramase requested a review from enj as a code owner August 23, 2023 19:26
@aramase aramase requested a review from sozercan August 23, 2023 19:27
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023 •
edited
Loading

Codecov Report

Merging #1092 (6da333d) into main (4a889b7) will increase coverage by 0.78%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
+ Coverage   53.89%   54.68%   +0.78%     
==========================================
  Files          36       36              
  Lines        2297     2297              
==========================================
+ Hits         1238     1256      +18     
+ Misses       1014      996      -18     
  Partials       45       45

see 1 file with indirect coverage changes

sozercan
sozercan approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aramase aramase enabled auto-merge (squash) August 23, 2023 23:15
@aramase aramase merged commit 41f2e5e into Azure:main Aug 24, 2023
22 checks passed
@aramase aramase deleted the aramase/t/add_proxy_test branch August 24, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sozercan sozercan sozercan approved these changes

@enj enj Awaiting requested review from enj enj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aramase @codecov-commenter @sozercan