Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump k8s deps to v1.29.4 and controller-runtime to v0.17.3 #1292

Merged
merged 3 commits into from
May 2, 2024

Conversation

aramase
Copy link
Member

@aramase aramase commented Mar 18, 2024

  • bump k8s deps to v1.29.4 and controller-runtime to v0.17.3

fixes #1312

@aramase aramase force-pushed the aramase/f/bump_deps_v1.29.x branch 2 times, most recently from c07bcc4 to 20271a6 Compare March 18, 2024 21:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 32.43243% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 52.55%. Comparing base (3874533) to head (4a2a7a5).
Report is 9 commits behind head on main.

Files Patch % Lines
cmd/webhook/main.go 0.00% 23 Missing ⚠️
pkg/webhook/webhook.go 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1292      +/-   ##
==========================================
+ Coverage   51.66%   52.55%   +0.88%     
==========================================
  Files          53       53              
  Lines        2938     2445     -493     
==========================================
- Hits         1518     1285     -233     
+ Misses       1378     1118     -260     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aramase aramase force-pushed the aramase/f/bump_deps_v1.29.x branch from 20271a6 to 3c951e2 Compare March 18, 2024 21:48
@aramase aramase force-pushed the aramase/f/bump_deps_v1.29.x branch 4 times, most recently from 455d0a7 to d4d40de Compare April 10, 2024 20:53
@aramase aramase marked this pull request as ready for review April 10, 2024 21:17
@aramase aramase requested a review from enj as a code owner April 10, 2024 21:17
@aramase aramase force-pushed the aramase/f/bump_deps_v1.29.x branch 2 times, most recently from 67a2f70 to ecf516e Compare April 22, 2024 17:23
@aramase aramase self-assigned this Apr 23, 2024
@YvesZelros
Copy link

YvesZelros commented Apr 23, 2024

@enj Can you look this pr, should fix this issue Kubernetes native sidecar not supported

@aramase aramase force-pushed the aramase/f/bump_deps_v1.29.x branch 2 times, most recently from b2940a1 to 4954d88 Compare April 26, 2024 18:53
@aramase aramase changed the title chore: bump k8s deps to v1.29.3 and controller-runtime to v0.17.2 chore: bump k8s deps to v1.29.4 and controller-runtime to v0.17.3 Apr 26, 2024
@aramase
Copy link
Member Author

aramase commented Apr 26, 2024

I've added a unit test in 9640c58 to assert the existing failure and the bump of deps fix it.

=== RUN   TestHandle/pod_has_the_required_label,_restart_policy_in_init_container
    webhook_test.go:806: expected no remove patches, got: {remove /spec/initContainers/0/restartPolicy <nil>}

@aramase aramase enabled auto-merge (squash) May 2, 2024 17:24
cmd/webhook/main.go Outdated Show resolved Hide resolved
@aramase aramase force-pushed the aramase/f/bump_deps_v1.29.x branch from 0e961ae to 4a2a7a5 Compare May 2, 2024 20:08
@aramase aramase requested a review from enj May 2, 2024 20:10
@aramase aramase merged commit 2a3942e into Azure:main May 2, 2024
23 checks passed
@aramase aramase deleted the aramase/f/bump_deps_v1.29.x branch May 2, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes native sidecar not supported
4 participants