Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add --enable-oidc-issuer to az aks create #305

Merged
merged 2 commits into from
Jan 6, 2022
Merged

test: add --enable-oidc-issuer to az aks create #305

merged 2 commits into from
Jan 6, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Jan 4, 2022

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

  • Adds --enable-oidc-issuer to az aks create. Although this issuer url isn't used in our tests yet, it'll help us catch any platform issues.
  • Updates the kubernetes version to 1.21 for AKS cluster

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase temporarily deployed to azwi-e2e January 4, 2022 19:08 Inactive
@aramase aramase temporarily deployed to azwi-e2e January 4, 2022 19:43 Inactive
@aramase aramase temporarily deployed to azwi-e2e January 4, 2022 19:55 Inactive
@aramase aramase temporarily deployed to azwi-e2e January 4, 2022 20:15 Inactive
@aramase aramase temporarily deployed to azwi-e2e January 4, 2022 20:23 Inactive
@aramase aramase temporarily deployed to azwi-e2e January 4, 2022 20:46 Inactive
@aramase aramase temporarily deployed to azwi-e2e January 4, 2022 21:52 Inactive
@aramase aramase temporarily deployed to azwi-e2e January 5, 2022 18:05 Inactive
@aramase aramase temporarily deployed to azwi-e2e January 5, 2022 19:28 Inactive
@aramase aramase temporarily deployed to azwi-e2e January 5, 2022 19:28 Inactive
@aramase aramase temporarily deployed to azwi-e2e January 5, 2022 19:29 Inactive
@aramase aramase marked this pull request as ready for review January 5, 2022 19:31
@aramase aramase requested a review from chewong as a code owner January 5, 2022 19:31
@aramase aramase changed the title test: add --enable-oidc-issuer to az aks create test: add --enable-oidc-issuer to az aks create Jan 5, 2022
Copy link
Contributor

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending @sozercan's re-review

@aramase aramase temporarily deployed to azwi-e2e January 5, 2022 22:46 Inactive
@aramase aramase requested a review from sozercan January 5, 2022 22:47
@aramase aramase temporarily deployed to azwi-e2e January 5, 2022 22:48 Inactive
@aramase aramase merged commit 5c12b64 into Azure:main Jan 6, 2022
@aramase aramase deleted the aks-oidc-issuer branch January 6, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants