Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use default service account when service account name is empty #446

Merged
merged 1 commit into from
May 10, 2022
Merged

fix: use default service account when service account name is empty #446

merged 1 commit into from
May 10, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented May 10, 2022

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

  • Resolves issue when pods using default service account in the namespace don't have the service account name set in the PodSpec.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #441

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase requested a review from chewong as a code owner May 10, 2022 15:21
@aramase aramase enabled auto-merge (squash) May 10, 2022 16:52
@aramase aramase merged commit 854b475 into Azure:main May 10, 2022
@aramase aramase deleted the fix-441 branch May 10, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chewong chewong chewong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Mutating webhook causes issues on Openshift when recreating kube-apiserver pods
2 participants
@aramase @chewong