Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting azure.workload.identity/use in annotations #479

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Jun 28, 2022

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

  • Allow setting azure.workload.identity/use in annotations in addition to labels

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #473

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

  • I'm thinking of updating the docs after v0.11.0 release

@aramase aramase marked this pull request as ready for review June 28, 2022 17:30
@aramase aramase requested a review from chewong as a code owner June 28, 2022 17:30
test/e2e/webhook.go Outdated Show resolved Hide resolved
@aramase aramase enabled auto-merge (squash) June 28, 2022 18:27
Co-authored-by: Ernest Wong <[email protected]>
Signed-off-by: Anish Ramasekar <[email protected]>
@aramase aramase merged commit 0171ac8 into Azure:main Jun 28, 2022
@aramase aramase deleted the use-wi-annotation branch June 28, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support using ServiceAccounts without label
2 participants