Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example with msal net and keyvault #52

Merged
merged 1 commit into from
Jun 4, 2021
Merged

feat: add example with msal net and keyvault #52

merged 1 commit into from
Jun 4, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Jun 3, 2021

Signed-off-by: Anish Ramasekar [email protected]

ref #4

@aramase aramase requested a review from chewong June 3, 2021 23:14
@aramase aramase enabled auto-merge (squash) June 3, 2021 23:33
@aramase aramase merged commit 3e165b2 into Azure:main Jun 4, 2021
Comment on lines +53 to +55
var client_id = Environment.GetEnvironmentVariable("AZURE_CLIENT_ID");
var token_path = Environment.GetEnvironmentVariable("TOKEN_FILE_PATH");
var tenant_id = Environment.GetEnvironmentVariable("AZURE_TENANT_ID");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
var client_id = Environment.GetEnvironmentVariable("AZURE_CLIENT_ID");
var token_path = Environment.GetEnvironmentVariable("TOKEN_FILE_PATH");
var tenant_id = Environment.GetEnvironmentVariable("AZURE_TENANT_ID");
var clientID = Environment.GetEnvironmentVariable("AZURE_CLIENT_ID");
var tokenPath = Environment.GetEnvironmentVariable("TOKEN_FILE_PATH");
var tenantID = Environment.GetEnvironmentVariable("AZURE_TENANT_ID");

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like auto-merge merged the PR. Let's fix this in a follow-up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants