Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use separate module for e2e #607

Merged
merged 2 commits into from
Oct 27, 2022
Merged

test: use separate module for e2e #607

merged 2 commits into from
Oct 27, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Oct 21, 2022

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

  • Use separate module for e2e tests and remove k8s.io/kubernetes dependency from the main module

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #602

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

Signed-off-by: Anish Ramasekar <[email protected]>
@aramase aramase marked this pull request as ready for review October 24, 2022 21:23
@aramase aramase requested review from sozercan and enj October 24, 2022 21:23
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aramase aramase enabled auto-merge (squash) October 27, 2022 18:38
@aramase aramase merged commit c6b1771 into Azure:main Oct 27, 2022
@aramase aramase deleted the test-gomod branch October 27, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s.io/kubernetes dependency in tests
2 participants