-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set expires_in
the proxy token response
#630
Conversation
expires_in
the proxy token response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Is there a way to test this with the addon ?
Once this is merged, you can use the nightly image build from here in your pod spec by manually editing the pod. This will be part of next release (2 weeks from now) post which AKS will update the add-on to use the new release. |
3ad5d47
to
4f5af77
Compare
Signed-off-by: Anish Ramasekar <[email protected]>
Signed-off-by: Anish Ramasekar [email protected]
Reason for Change:
expires_in
value. Computing that in the proxy based on current time and expires_on. This change is to make the response consistent with the IMDS response and also AAD response for token request.This is the AAD response:
xref: https://learn.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-auth-code-flow#successful-response-2
Requirements
Issue Fixed:
fixes #624
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers:
Opened AzureAD/microsoft-authentication-library-for-go#358 to request adding this as part of AuthResult, so we don't have to compute it.