Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use KEYVAULT_URL instead of KEYVAULT_NAME in quick start and tests #638

Merged
merged 3 commits into from
Nov 21, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Nov 16, 2022

Reason for Change:

  • use KEYVAULT_URL instead of KEYVAULT_NAME in quick start and tests
    • This enables testing the sample images in all clouds and not just AzurePublicCloud

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase marked this pull request as ready for review November 16, 2022 20:44
@aramase aramase requested review from enj and sozercan November 16, 2022 20:44
@aramase aramase merged commit f7755df into Azure:main Nov 21, 2022
@aramase aramase deleted the remove-keyvault-name branch November 21, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants