Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update msal-go example to use azidentity and azsecrets sdk #639

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Nov 17, 2022

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

  • update msal-go example to use azidentity and azsecrets sdk
    • This removes the dependency on autorest and switches the msal-go example to use track 2 sdks.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@ekarlso
Copy link

ekarlso commented Nov 20, 2022

@aramase Any idea on why this is failing? I tried your exampel but I only get "no token found" in a error

@aramase
Copy link
Member Author

aramase commented Nov 21, 2022

@aramase Any idea on why this is failing? I tried your exampel but I only get "no token found" in a error

@ekarlso It's WIP, i haven't had a chance to look at it yet. I'll mark it ready for review post testing.

@aramase aramase force-pushed the sdk/azsecrets/azidentity branch 2 times, most recently from ea3cc1c to 1527b3c Compare November 21, 2022 21:04
@aramase aramase marked this pull request as ready for review November 21, 2022 22:10
@aramase aramase requested review from enj and sozercan November 21, 2022 22:10
examples/msal-go/main.go Show resolved Hide resolved
@@ -4,83 +4,72 @@ import (
"context"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have tests for this example?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example is built and used as part of our e2e tests (ref: https://github.com/Azure/azure-workload-identity/blob/main/test/e2e/token_exchange.go)

@aramase aramase enabled auto-merge (squash) November 22, 2022 22:22
@aramase aramase merged commit 91bd8aa into Azure:main Nov 22, 2022
@aramase aramase deleted the sdk/azsecrets/azidentity branch November 22, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants