Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add minimum required permissions for creating federated identity credential #645

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Nov 22, 2022

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

  • Adds minimum required permissions for creating/deleting/updating federated identity credential with Azure AD Apps and user-assigned managed identity.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #548

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase
Copy link
Member Author

aramase commented Nov 22, 2022

cc @udayxhegde

@aramase aramase marked this pull request as ready for review November 22, 2022 00:42
docs/book/src/faq.md Outdated Show resolved Hide resolved
Copy link
Member

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aramase can we get an ack from someone in AAD to make sure we got this correct?

@aramase
Copy link
Member Author

aramase commented Nov 22, 2022

@aramase can we get an ack from someone in AAD to make sure we got this correct?

For sure! I've pinged @udayxhegde for review.

Copy link
Member Author

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with @udayxhegde on teams!

@aramase aramase merged commit 231c6be into Azure:main Nov 23, 2022
@aramase aramase deleted the permissions-doc branch November 23, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What are minimum permissions for a SPN to provision WI?
2 participants