Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove UPDATE operation from mutatingwebhookconfiguration #652

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Nov 29, 2022

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

  • If the pod is in terminating state, we return early in the handler as mutation/check doesn't apply to those.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

fixes #647

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase marked this pull request as ready for review November 29, 2022 21:09
@aramase aramase requested a review from enj November 29, 2022 21:09
pkg/webhook/webhook.go Outdated Show resolved Hide resolved
pkg/webhook/webhook.go Outdated Show resolved Hide resolved
pkg/webhook/webhook.go Outdated Show resolved Hide resolved
@aramase aramase changed the title fix: skip pods in terminating state fix: remove UPDATE operation from mutatingwebhookconfiguration Dec 6, 2022
@aramase aramase changed the title fix: remove UPDATE operation from mutatingwebhookconfiguration fix: remove UPDATE operation from mutatingwebhookconfiguration Dec 6, 2022
@aramase aramase requested a review from enj December 6, 2022 21:48
pkg/webhook/webhook_test.go Outdated Show resolved Hide resolved
@aramase aramase merged commit c4c898f into Azure:main Dec 7, 2022
@ringerc
Copy link

ringerc commented Nov 23, 2023

This change is described as

If the pod is in terminating state, we return early in the handler as mutation/check doesn't apply to those.

but in reality, the change appears to be to not fire the webhook on pod UPDATE at all. That's a bit confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod and namespace stuck in terminating state
3 participants