Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mutate pods based on pod label #653

Merged
merged 6 commits into from
Dec 7, 2022
Merged

Conversation

aramase
Copy link
Member

@aramase aramase commented Nov 29, 2022

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

  • Supports mutating based on azure.workload.identity/use label in the pod. This is done for backward compatibility.
  • Adds warning as part of admission response if pod is missing the required label.

Screenshot 2022-11-30 at 11 26 36 AM

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

part of #601

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase force-pushed the support-pod-label branch 3 times, most recently from 2deec2e to 5bdc060 Compare November 30, 2022 20:19
@aramase aramase marked this pull request as ready for review November 30, 2022 21:21
@aramase aramase requested a review from enj November 30, 2022 21:21
scripts/ci-e2e.sh Outdated Show resolved Hide resolved
pkg/webhook/webhook.go Outdated Show resolved Hide resolved
pkg/webhook/webhook.go Outdated Show resolved Hide resolved
test/e2e/webhook.go Show resolved Hide resolved
pkg/webhook/webhook.go Outdated Show resolved Hide resolved
@aramase aramase force-pushed the support-pod-label branch 3 times, most recently from 08055b0 to 388c006 Compare December 6, 2022 21:08
@aramase aramase requested a review from enj December 6, 2022 21:09
@enj enj enabled auto-merge (squash) December 7, 2022 21:52
Signed-off-by: Anish Ramasekar <[email protected]>
@enj enj merged commit b52c7f9 into Azure:main Dec 7, 2022
@aramase aramase deleted the support-pod-label branch December 7, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants