Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update quick start doc for user assigned identity #692

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

karataliu
Copy link
Contributor

@karataliu karataliu commented Jan 10, 2023

Previous code will return Unable to get object id from principal name.

Reason for Change:
Using --spn only works after a period of time ~60s, using --object-id works immediately.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase
Copy link
Member

aramase commented Jan 10, 2023

/azp run Azure Workload Identity CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

az keyvault set-policy --name "${KEYVAULT_NAME}" \
--secret-permissions get \
--spn "${USER_ASSIGNED_IDENTITY_CLIENT_ID}"
--object-id "${USER_ASSIGNED_IDENTITY_CLIENT_ID}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--object-id "${USER_ASSIGNED_IDENTITY_CLIENT_ID}"
--object-id "${USER_ASSIGNED_IDENTITY_OBJECT_ID}"

Copy link
Contributor Author

@karataliu karataliu Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. updated. it's interesting that previous one can also wrok.

@aramase aramase changed the title [DOC] Update quick start doc for user assigned identity docs: Update quick start doc for user assigned identity Jan 10, 2023
@aramase
Copy link
Member

aramase commented Jan 11, 2023

/azp run Azure Workload Identity CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@aramase aramase merged commit cba0c38 into Azure:main Jan 11, 2023
@karataliu karataliu deleted the patch-1 branch January 12, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants