feat: update webhook failure policy to Fail and set objectSelector #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
force-pushed
the
failclose
branch
7 times, most recently
from
572a5c0
to
e0b00c2
Compare
aramase
force-pushed
the
failclose
branch
6 times, most recently
from
e460ea9
to
0260107
Compare
enj
reviewed
Jan 24, 2023
.../templates/azure-wi-webhook-mutating-webhook-configuration-mutatingwebhookconfiguration.yaml
Outdated
Show resolved
Hide resolved
third_party/open-policy-agent/gatekeeper/helmify/static/values.yaml
Outdated
Show resolved
Hide resolved
aramase
force-pushed
the
failclose
branch
2 times, most recently
from
6d5b376
to
83a31d4
Compare
enj
approved these changes
Jan 24, 2023
- Sets failurePolicy to Fail - Added `azure.workload.identity/use: "true"` label in objectSelector - Regenerated helm charts and manifests Signed-off-by: Anish Ramasekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
azure.workload.identity/use: "true"azure.workload.identity/use: "true"label will be mutated by the workload identity mwhmutatingWebhookFailurePolicyandmutatingWebhookObjectSelectorhelm configurations and set defaults for bothRequirements
Issue Fixed:
part of #601
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: