-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: explicitly set runAsNonRoot to false (#697) #698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of those should be done in my latest push. Thanks for the quick response! |
/azp run Azure Workload Identity CI |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update the struct in the unit tests?
azure-workload-identity/pkg/webhook/webhook_test.go
Lines 1254 to 1255 in f41afae
Privileged: pointer.BoolPtr(true), | |
RunAsUser: pointer.Int64Ptr(0), |
@dhduvall Have you agreed to the CLA? The bot still says |
@microsoft-github-policy-service agree |
/azp run Azure Workload Identity CI |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @dhduvall!
Reason for Change:
See #697.
Requirements
Issue Fixed:
Fixes #697
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: