Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly set runAsNonRoot to false (#697) #698

Merged
merged 1 commit into from
Jan 13, 2023
Merged

fix: explicitly set runAsNonRoot to false (#697) #698

merged 1 commit into from
Jan 13, 2023

Conversation

dhduvall
Copy link
Contributor

Reason for Change:
See #697.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:
Fixes #697

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase changed the title explicitly set runAsNonRoot to false (#697) fix: explicitly set runAsNonRoot to false (#697) Jan 12, 2023
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @dhduvall!

  1. could you update the commit message to be semantic fix: explicitly set runAsNonRoot to false (#697).
  2. Rebase on main branch

@dhduvall
Copy link
Contributor Author

Thank you for the PR @dhduvall!

1. could you update the commit message to be [semantic](https://github.com/Azure/azure-workload-identity/blob/main/.github/semantic.yml) `fix: explicitly set runAsNonRoot to false (#697)`.

2. Rebase on `main` branch

Both of those should be done in my latest push. Thanks for the quick response!

@aramase
Copy link
Member

aramase commented Jan 12, 2023

/azp run Azure Workload Identity CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the struct in the unit tests?

Privileged: pointer.BoolPtr(true),
RunAsUser: pointer.Int64Ptr(0),

@aramase
Copy link
Member

aramase commented Jan 13, 2023

@dhduvall Have you agreed to the CLA? The bot still says Contributor License Agreement is not agreed yet.

@dhduvall
Copy link
Contributor Author

@microsoft-github-policy-service agree

@aramase
Copy link
Member

aramase commented Jan 13, 2023

/azp run Azure Workload Identity CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @dhduvall!

@aramase aramase merged commit 03e849e into Azure:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxy-init container doesn't set runAsNonRoot: false
2 participants