fix: use generate name in logs if pod name is empty #706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar [email protected]
Reason for Change:
For static pods, the pod name is not empty. For pods created as part of
Deployments
,ReplicaSet
, etc, the name is empty and generate name exists.Actual log with this change
I0117 23:13:27.617001 1 webhook.go:142] handler "msg"="pod not labeled or service account not annotated, skipping mutation" "namespace"="default" "pod"="nginx-deployment-85996f8dbd- (prefix)" "service-account"="default"
Requirements
Issue Fixed:
fixes #688
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: